Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean-up #66

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Clean-up #66

merged 4 commits into from
Oct 15, 2024

Conversation

barucden
Copy link
Collaborator

Rebased the changes from @ExpandingMan and applied suggestions from @omus.

Closes #42

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (490309b) to head (5348022).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   99.22%   97.70%   -1.52%     
==========================================
  Files           6        6              
  Lines         129      131       +2     
==========================================
  Hits          128      128              
- Misses          1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Member

These kinds of PRs are straightforward. Please merge away!

@barucden barucden merged commit 398e636 into JuliaMath:master Oct 15, 2024
7 of 8 checks passed
@barucden barucden deleted the em-overhaul branch October 15, 2024 16:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants