Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Addition: dectests + implementation #80

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

barucden
Copy link
Collaborator

@barucden barucden commented Nov 1, 2024

Requires #75

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (73e7c86) to head (ecdb301).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   99.64%   99.66%   +0.02%     
==========================================
  Files          11       11              
  Lines         280      301      +21     
==========================================
+ Hits          279      300      +21     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barucden
Copy link
Collaborator Author

barucden commented Nov 1, 2024

div(::BigInt, ::BigInt, RoundFromZero) was added in Julia 1.9. How should I deal with that method missing in Julia 1.8? I wouldn't want to remove those tests altogether.

@barucden barucden merged commit f432460 into JuliaMath:master Nov 3, 2024
7 checks passed
@barucden barucden deleted the add-dectest branch November 3, 2024 14:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant