Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use JLL package to provide GSL binary library #104

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

giordano
Copy link
Member

This is only a proof-of-concept to show how this package will look like using the new JLL artifacts.

This pull requested is not intended to be merged yet, as it requires Julia 1.3.

@codecov-io
Copy link

codecov-io commented Oct 26, 2019

Codecov Report

Merging #104 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #104      +/-   ##
=========================================
+ Coverage    6.99%   7.03%   +0.03%     
=========================================
  Files         189     189              
  Lines        5348    5277      -71     
=========================================
- Hits          374     371       -3     
+ Misses       4974    4906      -68
Impacted Files Coverage Δ
src/GSL.jl 88.88% <ø> (ø) ⬆️
src/gen/direct_wrappers/gsl_sf_legendre_h.jl 9.09% <0%> (-1.82%) ⬇️
src/gen/direct_wrappers/gsl_vector_ushort_h.jl 0% <0%> (ø) ⬆️
src/gen/direct_wrappers/gsl_vector_char_h.jl 0% <0%> (ø) ⬆️
src/gen/direct_wrappers/gsl_vector_short_h.jl 0% <0%> (ø) ⬆️
.../gen/direct_wrappers/gsl_vector_complex_float_h.jl 0% <0%> (ø) ⬆️
...rc/gen/direct_wrappers/gsl_vector_long_double_h.jl 0% <0%> (ø) ⬆️
src/gen/direct_wrappers/gsl_vector_uint_h.jl 0% <0%> (ø) ⬆️
src/gen/gsl_global_vars.jl 100% <0%> (ø) ⬆️
src/gen/direct_wrappers/gsl_sf_hermite_h.jl 0% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98c48d...96a669b. Read the comment docs.

@ViralBShah
Copy link
Member

@giordano Should we get this one merged?

@giordano giordano closed this Mar 28, 2020
@giordano giordano reopened this Mar 28, 2020
@giordano
Copy link
Member Author

Travis is not running because this is a draft PR. I'm opening for review to see how it goes

@giordano giordano marked this pull request as ready for review March 28, 2020 16:47
@giordano giordano force-pushed the jll_pkg branch 2 times, most recently from 96a669b to 7374127 Compare March 28, 2020 17:02
@ViralBShah
Copy link
Member

Only the nightly Julia windows is failing. So I think we can merge.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants