Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use RealDot.realdot for more efficient real(dot(x, y)) #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devmotion
Copy link
Member

This PR uses RealDot.realdot to perform computations of real(dot(x, y)) more efficiently. RealDot.jl is a very lightweight package that only defines realdot and only depends on LinearAlgebra: https://github.com/JuliaMath/RealDot.jl/blob/main/src/RealDot.jl

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #355 (2d6a42f) into master (c4b0b83) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files          12       12           
  Lines        2687     2687           
=======================================
  Hits         2506     2506           
  Misses        181      181           
Flag Coverage Δ
unittests 93.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SpecialFunctions.jl 100.00% <ø> (ø)
src/chainrules.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b0b83...2d6a42f. Read the comment docs.

@stevengj
Copy link
Member

I appreciate the thought here, but I'm skeptical that this can possibly matter much here given the cost of evaluating the Bessel functions.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants