Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

README typo: global ref[] = ... #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fonsp
Copy link

@fonsp fonsp commented Dec 2, 2023

Hey! Scratch is cool!

Little typo fix in the README: a ref change does not need the global keyword

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d68e430) 87.73% compared to head (a1bda7b) 87.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files           1        1           
  Lines         106      106           
=======================================
  Hits           93       93           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredrikekre
Copy link
Member

Quite a bit have changed since this was written. In particular there is now Base.pkgversion, so I think all of this can be replaced by e.g.

version_specific_scratch = let pkg_version = pkgversion(@__MODULE__)
    scratch_name = "data_for_version-$(pkg_version.major).$(pkg_version.minor)"
    @get_scratch!(scratch_name)
end

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants