Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

simplified qsub call, fixed kill, added working dir option + some tests #153

Merged
merged 3 commits into from
Dec 23, 2020
Merged

simplified qsub call, fixed kill, added working dir option + some tests #153

merged 3 commits into from
Dec 23, 2020

Conversation

nantonel
Copy link
Contributor

@nantonel nantonel commented Nov 20, 2020 •
edited
Loading

Addressing #151 #152 #103

@nantonel nantonel changed the title simplified qsub call, fixed kill + some tests simplified qsub call, fixed kill, added working dir option + some tests Nov 27, 2020
@Moelf
Copy link
Collaborator

Moelf commented Dec 23, 2020

this is great, I hope someone review this

@bjarthur bjarthur merged commit 0e9b133 into JuliaParallel:master Dec 23, 2020
@bjarthur
Copy link
Collaborator

thanks!

@bjarthur
Copy link
Collaborator

note that if you say "closes #151... etc" instead of "Addressing" then those issues will be automatically closed when this PR is merge.

This was referenced Dec 23, 2020
Closed
Closed
Closed
This was linked to issues Dec 23, 2020
addprocs_sge works incorrectly if the work directory is not the home directory and the list of default options for qsub includes "-cwd" #103
Closed
Extra options on SGE #151
Closed
Error in rmprocs SGE #152
Closed
@kescobo
Copy link
Collaborator

kescobo commented Dec 23, 2020

Can add the links manually in the sidebar too 👍 thanks for doing it!

@kescobo kescobo mentioned this pull request Dec 23, 2020
Closed
@Moelf
Copy link
Collaborator

Moelf commented Dec 25, 2020 

julia> addprocs_sge(5;queue=`-l h_vmem=4G,tmem=4G`, wd=mktempdir())
Unable to run job: unknown resource "tmem".
Exiting.
Error launching workers
ErrorException("")
Int64[]

I think this PR broke previously working version for out SGE

@Moelf Moelf mentioned this pull request Dec 26, 2020
Closed
@Moelf Moelf mentioned this pull request Jan 8, 2021
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nantonel @Moelf @bjarthur @kescobo