Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

attempt at scaling linestyle patterns by linewidth #157

Merged
merged 1 commit into from
Apr 12, 2021
Merged

attempt at scaling linestyle patterns by linewidth #157

merged 1 commit into from
Apr 12, 2021

Conversation

greimel
Copy link
Contributor

@greimel greimel commented Jan 7, 2021

Companion to JuliaPlots/AbstractPlotting.jl#593 to fix MakieOrg/Makie.jl#807

I will need your help here, @SimonDanisch. What is the unit of linewidth? And what is the unit of the linestyle patterns? I need this to figure out the right scaling. I now scaled by linewidth/4 and it doesn't look too bad.

This is what I am getting now.

image

EDIT: The sentence didn't make sense, sorry.

@greimel
Copy link
Contributor Author

greimel commented Jan 7, 2021

fixed a stupid mistake and updated the picture. It looks quite nice now. But ideally, you tell me the correct scaling factor.

@SimonDanisch
Copy link
Member

SimonDanisch commented Apr 12, 2021

Sorry for the neglect! To be honest, I'm not 100% sure what the scaling should be...
In theory, linewidth should be in pixels! But I haven't looked at the actual shaders that draw this in years...
Thanks, I'm going to merge this. I wanted to refactor the shaders a bit anyways going forward, which is when we can correct the scaling factor!

@SimonDanisch SimonDanisch merged commit 60f6a12 into JuliaPlots:master Apr 12, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve linestyles (including a fix for broken line styles in CairoMakie)
2 participants