Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
with_terminal to capture stdout and stdin #31
with_terminal to capture stdout and stdin #31
Changes from 1 commit
6435c33
05b919d
8dab150
3a1e811
9cbf04e
9fa7555
65a271f
1a194cc
df89110
12570e7
46995c0
436c542
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why create a macro that does exactly the same as
if
? This makes code harder to understandThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not exactly the same if I want to use this with a begin/end block.
I can have
but I must have
with two ends at the end.
But I see some point in your remark (see above).
It comes down to finding the right usage patterns. I envision to explain to new uses the working of pluto before anything else and might explain things both ways. In this sense it appears to be more important to find a proper variable name instead of
test
than insisting on @cond.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this macro has 2 (small) advantages over if:
if
and theend
, resulting in slightly less typing.However, I agree that the benefit of it is not huge and therefore it is more a matter of taste. Alternatively, the if-pattern could be documented as officially recommended.