Require distances keyword for MDS
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
changed the title
distances keyword for MDS
`fit(MDS, ...)` lacked documentation, and consequently I simply assumed that one passed a matrix of distances. This did not trigger any errors, but the results were nonsense. We can address this by requiring the user to provide the `distances` keyword.
Also update CI
|
Test failure seems unrelated. |
|
Friendly bump. Anything I need to do to get this merged? |
|
This package is rather undermaintained. I've invited you for write access. The changes here look reasonable to me but I'm not familiar with this method. |
|
Thanks! I'll give it another couple of days and then merge if no one complains. |
|
Eh, people have had 16 days to complain; if they were going to, they probably already would have 😄 |
|
Yeah, but now they know I'm dangerous 😈 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fit(MDS, ...)lacked documentation, and consequently I simply assumedthat one passed a matrix of distances. This did not trigger any errors, but the
results were nonsense, because the distances matrix was interpreted as
a data matrix.
We can address this by requiring the user to provide the
distanceskeyword.Note that this is a breaking change and so I've taken liberty to bump the minor version.