Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Faster startup #95

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Faster startup #95

merged 1 commit into from
Jun 14, 2020

Conversation

PallHaraldsson
Copy link
Contributor

No description provided.

@PallHaraldsson
Copy link
Contributor Author

Faster, see my PR here: JuliaInterop/RCall.jl#383 and very likely no potential downside/slowdown here.

asinghvi17
asinghvi17 approved these changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@asinghvi17 asinghvi17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since RDatasets is a user-facing library, and mostly just calls out to CSV anyway, this makes sense to me.

@asinghvi17
Copy link
Collaborator

Thanks!

@asinghvi17 asinghvi17 merged commit b744dc7 into JuliaStats:master Jun 14, 2020
@PallHaraldsson PallHaraldsson deleted the patch-1 branch June 14, 2020 12:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@asinghvi17 asinghvi17 asinghvi17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PallHaraldsson @asinghvi17