Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ignore CRLF/LF difference #40

Merged
merged 3 commits into from
Dec 14, 2019
Merged

ignore CRLF/LF difference #40

merged 3 commits into from
Dec 14, 2019

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Dec 14, 2019 •
edited
Loading

closes #39

This fixes a CRLF/LF "bug" that exists locally on Windows:

Test for "string1.nottxt" failed.
- DIFF ------------------------
"""
- This is not a .txt file, but it should be treated as such.\r
+ This is not a .txt file, but it should be treated as such.
  """

@coveralls
Copy link

coveralls commented Dec 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-4.6%) to 77.692% when pulling 9c7337a on jc/crlf into 46d650a on master.

@oxinabox
Copy link
Member

LGTM, can you add a test, and bump the version

@johnnychen94
Copy link
Member Author

I'll merge this once the test passes

@johnnychen94 johnnychen94 merged commit 148f181 into master Dec 14, 2019
@johnnychen94 johnnychen94 deleted the jc/crlf branch December 14, 2019 20:36
johnnychen94 added a commit to johnnychen94/ReferenceTests.jl that referenced this pull request Jul 5, 2020
@johnnychen94
ignore CRLF/LF difference
4c0fc6c 
continues JuliaTesting#40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore the difference between \n\r and \r?
3 participants
@johnnychen94 @coveralls @oxinabox