Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

save converted actual result as reference #50

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Jan 12, 2020

For images as txt, we should save the converted string contents: savefile(file, actual) instead of images savefile(file, raw_actual).

Another bug I introduced in #37 😂

No test for this because interactive REPL is required.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 83.721% when pulling a347c6e on jc/new_ref into 9a5ae50 on master.

@johnnychen94
Copy link
Member Author

johnnychen94 commented Jan 12, 2020

I forgot to do a rebase on latest master branch before pushing this. Since the PR test has passed I'll just merge it without waiting for another round of tests.

@johnnychen94 johnnychen94 merged commit b8dae6a into master Jan 12, 2020
@johnnychen94 johnnychen94 deleted the jc/new_ref branch January 12, 2020 07:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants