feat: ignore case when matching yml configuration to GitHub author #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @JulienKode , I've also added a test for that change. Please let me know if I can help further with this! |
|
Hello @JulienKode , any news on this? Please let me know if I can help in any way to get this merged |
|
Hi @7PH Thanks for handling this and doing it ! Sorry I missed all of my github notification I'll review it soon |
JulienKode
approved these changes
Jan 3, 2024
|
No worry! Thanks for taking the time to review and merge this 😁 |
greg-agacinski
pushed a commit
to nobl9/team-labeler-action
that referenced
this pull request
Mar 1, 2024
* feat: ignore case when matching yml configuration to GitHub author (JulienKode#216) * chore(deps): update dependency eslint to v8.56.0 (JulienKode#218) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @typescript-eslint/parser to v5.62.0 (JulienKode#215) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/js-yaml to v4.0.9 (JulienKode#213) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v18.19.4 (JulienKode#214) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/jest to v29.5.11 (JulienKode#212) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vercel/ncc to v0.38.1 (JulienKode#217) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: Benjamin Raymond <31401273+7PH@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for case-insensitive matching when comparing the github usernames from the yml configuration to the GitHub actual username.
Coincidentally, I've seen that someone opened an issue for the same feature request.