Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(master): release 3.5.0 #27

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

Julusian
Copy link
Owner

🤖 I have created a release beep boop

3.5.0 (2024-07-14)

Features


This PR was generated with Release Please. See documentation.

@Julusian Julusian merged commit c5170b3 into master Jul 14, 2024
20 checks passed
@Julusian
Copy link
Owner Author

@BogdanDenis
Copy link

Hey @Julusian, the new constants don't seem to be included in the npm package which causes these errors:

ERROR in ./node_modules/@julusian/midi/midi.js 12:20-44
Module not found: Error: Can't resolve './instruments' in 'C:\Users\dbohdan\Documents\programming\midiJoy\node_modules\@julusian\midi'
 @ ./src/controllers/midi/midi.js 4:13-38
 @ ./src/main.js

ERROR in ./node_modules/@julusian/midi/midi.js 14:14-32
Module not found: Error: Can't resolve './drums' in 'C:\Users\dbohdan\Documents\programming\midiJoy\node_modules\@julusian\midi'
 @ ./src/controllers/midi/midi.js 4:13-38
 @ ./src/main.js

ERROR in ./node_modules/@julusian/midi/midi.js 16:14-32
Module not found: Error: Can't resolve './notes' in 'C:\Users\dbohdan\Documents\programming\midiJoy\node_modules\@julusian\midi'
 @ ./src/controllers/midi/midi.js 4:13-38
 @ ./src/main.js

ERROR in ./node_modules/@julusian/midi/midi.js 18:17-38
Module not found: Error: Can't resolve './messages' in 'C:\Users\dbohdan\Documents\programming\midiJoy\node_modules\@julusian\midi'
 @ ./src/controllers/midi/midi.js 4:13-38
 @ ./src/main.js

I can use 3.4.0 for now, just wanted to give a heads up.
P.S.: Really awesome package - people who create Node wrappers for C/C++ DLLs are the real heroes!

@Julusian
Copy link
Owner Author

@BogdanDenis thanks for letting me know, 3.5.3 is building now which should resolve this

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants