Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Setting default version to both 7 and 8 #261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CodingDK
Copy link
Contributor

I changed the "default" version to support both 7 and 8. Because the version is set to 7 - most of the converteres are not used.

I am aware that this may not be the desired logic - alternatively, the version must be set on all migrators that are desired for 7 or 8.

@KevinJump
Copy link
Member

yeah - not sure - doing some other refactoring so i will check this one. in theory should be fine,

@CodingDK
Copy link
Contributor Author

You should not merge it into main yet. I used the changes on a work project earlier this week. It removes config values and converts incorrectly on¨some properties during an umbraco 8 migration (eg mediapicker -> mediaPicker3) - because these migrators only handle "prevalues" and not config.

@KevinJump
Copy link
Member

Yes, increasingly i am thinking there are two categories of migration,

a) hard v7 ones,
b) less hard v8 ones. :)

I am sort of aiming for splitting thigns a little bit, so in theory we can have the 'less hard' v8 stuff happen in a way that means we can us it in uSync proper

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants