Added fix to handle mode telnet #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshbaburam91
approved these changes
May 9, 2024
dineshbaburam91
approved these changes
May 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To handle mode= telnet and port = 23
isinstance(dev, Device): returns False for device handle with mode=telnet and port=23,
added another check to if dev is not None and proceed with execution
What issues does this PR fix or reference?
Ansible issue
Juniper/ansible-junos-stdlib#535
Previous Behavior
Remove this section if not relevant
"msg": "Uncaught exception - please report: not all arguments converted during string formatting"
Tests written?
Yes/No
Need update in inventory
local_connection_testcases ansible_host=x.x.x.x ansible_user=xyz ansible_pass=xyz ansible_port=23 mode=telnet ansible_connection=local ansible_command_timeout=300