-
-
Notifications
You must be signed in to change notification settings - Fork 465
Fix build error #3416
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix build error #3416
Conversation
In the latest update, here are what I've done:
|
@zukilover please look into upgrade PR branch - a lot of what you are doing is already done there. |
not sure if adding type: module in package.json is ok for a package, cos it will ruin the day for those who is on old frameworks. |
@zukilover Sorry, I have re-target your PR to upgrade branch, hence merge conflicts. Can you resolve it? if not, I can help out. |
@zukilover Awesome work, could not have done it better myself. |
Sure, I'll work on resolving the conflicts. |
Yeah this could be problematic, I'll see if I can keep it as it was. |
@zukilover |
@zukilover are you going to continue on this PR? |
3f4f5f9
to
75dc231
Compare
@JustFly1984 Hi, sorry for the late update. After reviewing the upgrade branch, I can see what you mentioned about a lot of the work already being there. What I did from the latest rebase was to fix the build from the styleguidist config file — this works for me now. Let me know if this looks good to you. I switched to CommonJS (require) locally in the config and updated the Webpack setup to make it compatible. |
This PR addresses build system issues and TypeScript configuration problems in the react-google-maps-api package. The changes improve type safety and modernize the build process while maintaining compatibility with existing code.
Build System Updates
rollup-plugin-terser
with@rollup/plugin-terser
for rollup v3 compatibilitytype: "module"
to package.json for proper ESM supportTypeScript Configuration
importsNotUsedAsValues
withverbatimModuleSyntax
es2015
to lib array in root tsconfig.json@types/invariant
type
import syntaxCode Organization
default-load-script.ts
utility fileThe build process now completes successfully. There are some TypeScript warnings in test files that don't affect the build output and can be addressed separately.