Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ntfy.sh notification provider #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Avi0n
Copy link

@Avi0n Avi0n commented Jun 24, 2024

Added ntfy.sh notication provider. All it needs is the ntfy topic. ntfy.sh docs for reference: https://docs.ntfy.sh/publish/

@ndrone
Copy link
Contributor

ndrone commented Jun 24, 2024

Could this replace all the other notification types?

@Avi0n
Copy link
Author

Avi0n commented Jun 24, 2024

@ndrone Sorry, what do you mean by replace? Do you mean remove all other notification providers other than ntfy.sh? Or that my code has a problem?

@ndrone
Copy link
Contributor

ndrone commented Jun 24, 2024

@ndrone Sorry, what do you mean by replace? Do you mean remove all other notification providers other than ntfy.sh? Or that my code has a problem?

yes replace all other notification providers.

@Avi0n
Copy link
Author

Avi0n commented Jun 24, 2024

Ah I see. I feel Slack and Discord would still be useful since they are much more popular platforms than ntfy.sh, but I will of course leave it up to the maintainer.

@K0p1-Git
Copy link
Owner

while I think its a good addition, slack and discord are still common. Hence, I don't think it should be removed.

Add ntfy notification provider, including support for custom ntfy servers.
@Avi0n
Copy link
Author

Avi0n commented Jun 25, 2024

That was my thought as well. This PR doesn't remove any notification providers, it just adds ntfy.

I realized ntfy also supports self-hosting the server, so I added support for custom URI's as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants