Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for arbitrary waveform generators #26

Closed
crnbaker opened this issue May 26, 2023 · 0 comments · Fixed by #41
Closed

Support for arbitrary waveform generators #26

crnbaker opened this issue May 26, 2023 · 0 comments · Fixed by #41
Assignees
@crnbaker

Comments

@crnbaker
Copy link
Collaborator

crnbaker commented May 26, 2023 •
edited
Loading

We need to support arbitrary waveform generators as well as digitisers. This will likely require some refactoring of the class hierarchy (and some renaming - SpectrumDevice will likely become SpectrumDigitiser, for example). This work will likely form the bulk of the version 1 release.

Refactoring was done in PR #29
@crnbaker crnbaker self-assigned this May 26, 2023
@crnbaker crnbaker mentioned this issue May 26, 2023
Merged
crnbaker added a commit that referenced this issue Jun 1, 2023
@crnbaker
#26 - refactored devices package to have separate abstract classes fo…
0d46401 
…r cards and hubs
crnbaker added a commit that referenced this issue Jun 1, 2023
@crnbaker
#26 - card and hub implementations completes
d9ebfe3
crnbaker added a commit that referenced this issue Jun 1, 2023
@crnbaker
#26 - device classes added to subpackage __init__.py files
84f347c
crnbaker added a commit that referenced this issue Jun 1, 2023
@crnbaker
#26 - Updated docstrings for abstract_spectrum_card.py, abstract_spec…
72e1477 
…trum_device.py and device_interface.py
@crnbaker crnbaker mentioned this issue Jun 1, 2023
Merged
4 tasks
crnbaker added a commit that referenced this issue Jun 2, 2023
@crnbaker
#26 - Updated docstrings for abstract_spectrum_hub.py
6e413b4
crnbaker added a commit that referenced this issue Jun 2, 2023
@crnbaker
#26 - Updated docstrings for digitiser package
3b0c6b5
crnbaker added a commit that referenced this issue Jun 2, 2023
@crnbaker
#26 - Updated docstrings for digitiser package
8caab1e
crnbaker added a commit that referenced this issue Jun 2, 2023
@crnbaker
#26 - Updated README.md
7a692f4
crnbaker added a commit that referenced this issue Jun 2, 2023
@crnbaker
#26 - Updated reference docs
1af8df8
crnbaker added a commit that referenced this issue Jun 8, 2023
@crnbaker
#26 - AWG interface and implementation underway
912b1d4
crnbaker added a commit that referenced this issue Jun 8, 2023
@crnbaker
#26 - AWG channel settings implemented
b5f36a7
crnbaker added a commit that referenced this issue Jun 8, 2023
@crnbaker
#26 - Generation mode Enum and properties implemented
9c38514
crnbaker added a commit that referenced this issue Jun 19, 2023
@crnbaker
#26 - refactored TransferBuffer to use factories rather than inheritence
9e02448
crnbaker added a commit that referenced this issue Jun 19, 2023
@crnbaker
#26 - started implementing SpectrumAWGCard
ae4a20f
crnbaker added a commit that referenced this issue Jul 5, 2023
@crnbaker
#26 - linting
ba82cf6
crnbaker added a commit that referenced this issue Jul 5, 2023
@crnbaker
#26 - abstract spectrum awg
51e788b
crnbaker added a commit that referenced this issue Jul 5, 2023
@crnbaker
#26 - Added option to set a notify size smaller than the data length …
260b894 
…in transfer_buffer.py, and made use of it in SpectrumDigitiserCard.get_waveforms()
crnbaker added a commit that referenced this issue Dec 19, 2023
@crnbaker
#26 - implemented AWG init_channels
764ee82
crnbaker added a commit that referenced this issue Dec 21, 2023
@crnbaker
#26 - made abstract card a Generic class with channel type as type va…
ca9cd63 
…riable so channels property of AWG cards and digitiser cards provides the expected Channel type.
crnbaker added a commit that referenced this issue Dec 21, 2023
@crnbaker
#26 - made abstract star hub a Generic with type variable defining ty…
f2f65d6 
…pe of child card (digitiser or AWG). And implemented IOLine as a new type of channel.
crnbaker added a commit that referenced this issue Dec 21, 2023
@crnbaker
#26 - implemented DigOut IO LIne functionality for AWGs
c18b694
crnbaker added a commit that referenced this issue Jan 8, 2024
@crnbaker
#26 - device class hierarchy refactored to use super()
758d47e
crnbaker added a commit that referenced this issue Jan 9, 2024
@crnbaker
#26 - mock device param dict now created in MockAbstractSpectrumDevic…
303e416 
…e with option to pass a value for it. This means values can be preconfigured by child classes if necessary.
crnbaker added a commit that referenced this issue Jan 9, 2024
@crnbaker
#26 - tests passing with super()
7ebe269
crnbaker added a commit that referenced this issue Jan 9, 2024
@crnbaker
#26 - mock awg implemented
a40d43f
crnbaker added a commit that referenced this issue Jan 9, 2024
@crnbaker
#26 - awg example script implemented
93a36ac
crnbaker added a commit that referenced this issue Jan 11, 2024
@crnbaker
#26 - implemented awg unit tests
913fdd4
crnbaker added a commit that referenced this issue Jan 11, 2024
@crnbaker
#26 - implemented awg unit tests
2550859
crnbaker added a commit that referenced this issue Jan 11, 2024
@crnbaker
#26 - awg tests on hardware
14b4243
crnbaker added a commit that referenced this issue Jan 11, 2024
@crnbaker
#26 - removed synchronous digital output from example (see issue #40)
d327d3f
crnbaker added a commit that referenced this issue Jan 11, 2024
@crnbaker
#26 - removed synchronous digital output from example (see issue #40)
5685e47
@crnbaker crnbaker mentioned this issue Jan 11, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@crnbaker crnbaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Arbitrary waveform generator support KCL-BMEIS/spectrumdevice
1 participant
@crnbaker