Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use python 3.11 to run pre-commit on the ci #547

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

lievenhey
Copy link
Contributor

@lievenhey lievenhey commented Oct 30, 2023

the old pre-commit action broke and is no longer working I relpaced it with pre-commit-lite which support auto fixup

python got updated to 3.12 which broke pre-commit

@lievenhey lievenhey force-pushed the fix-precommit branch 4 times, most recently from f1a0dab to 232c46f Compare October 30, 2023 12:59
@lievenhey lievenhey changed the title port away from deprecated pre-commit action use python 3.11 to run pre-commit on the ci Oct 30, 2023
actions/setup-python seems to always use the newest python version by
default. This broke the ci since apparently pre-commit is not compatible
with python 3.12. Fixed by forcing it to run with python 3.11
Copy link
Member

@milianw milianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@lievenhey lievenhey merged commit 33dbc44 into master Oct 30, 2023
@lievenhey lievenhey deleted the fix-precommit branch October 30, 2023 13:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants