add support for kddockwidgets 2.0 #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to keep building ubuntu 20.04 with kddw 1.6 and let the rest use kddw 2.0. This should take care that we stay compatible with earlier versions. |
milianw
requested changes
Dec 8, 2023
|
Can you please also update https://github.com/KDAB/hotspot/blob/master/scripts/appimage/Dockerfile to use the new version? While the docs say that 2.0 doesn't brings much from the user-view, it seems to be reasonable to update KDAB software in its appimages. |
this patch fixes the compile errors with kddockwidgets 2.0 but keeps compatibility with earlier versions fixes: #569
lievenhey
force-pushed
the
kddockwidgets-2.0
branch
from
5480d02 to
d93d905
Compare
archlinux: the kde packages were renamed from ksomething to ksomething5
lievenhey
force-pushed
the
kddockwidgets-2.0
branch
from
d93d905 to
f05b19c
Compare
milianw
approved these changes
Dec 11, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch fixes the compile errors with kddockwidgets 2.0 but keeps compatibility with earlier versions
fixes: #569