Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Point KourageousTourists at Lisias' fork on spacedock #9921

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

JonnyOThan
Copy link
Contributor

@JonnyOThan JonnyOThan commented Feb 6, 2024

Note: transfer was approved by original author here: https://forum.kerbalspaceprogram.com/topic/209560-ksp-131-kourageous-tourists-l-0601-2022-1128/#comment-4224575

A few issues/questions for @Lisias :

  • Despite using the same identifier, ckan will use the name of the mod from spacedock - i.e. "Kourageous Tourists /L." If you're OK with that there's nothing we need to do, or else we can override it in the netkan.
  • I explicitly listed the authors here because your spacedock listing doesn't have whale_2 listed as an author (nor should it necessarily, unless you want them to be able to modify your releases etc). Since the original license was MIT I think listing whale_2 in CKAN is required, but in any case it's nice to give credit to previous authors and I don't think you'd have a problem with this anyway. Of course let me know if you have any objections.
  • Some of your mods use "Lisias" and some use "LisiasT" in the author field - which would you prefer? I think since your spacedock account is named Lisias the ones that are auto-populated from there are using that name. We might want to make these more consistent at some point.
  • Note that your original PR used replaced-by metadata. Simply re-using the old identifier is cleaner as long as the previous mod author is OK with it (as they seem to be). We only have one example of replaced-by in use and it's a case where multiple mods were combined into one.
  • Your installation instructions say that KSPe is a dependency, but it's not indexed on CKAN. And I just noticed that the release notes say "Replaces KSPe external dependency with embedded KSPe.Light" - can you clarify what is actually needed here?
  • Any changes to the tags I chose? https://github.com/KSP-CKAN/CKAN/wiki/Suggested-Tags
  • Any other recommend/suggest/supports relationships you want to include? Please review the relationships documentation here if you haven't in a while, it's changed recently: https://github.com/KSP-CKAN/CKAN/blob/master/Spec.md#relationships
  • CKAN now supports multiple-host metadata, in case you want to support downloading from both SpaceDock and Github in case one goes down. But specifying that in the metadata is pretty clunky - if that's something you're interested in doing we can always add it later.

still need to hear from Lisias about what the correct dependencies are, but at least this way if the netkan is correct as-is then we don't need to change it again
I had originally thought that this must include some kind of contract config pack but that appears to not actually be the case
@Lisias
Copy link
Contributor

Lisias commented Feb 6, 2024

Hi.

I have agreement with whale_2 to maintain KT, but couldn't reached him to make a deal about SpaceDock. So I assumed he wanted to keep their entry for himself.

I agree about "Lisias" versus "LisiasT". "LisiasT" happened because someone else found a good idea to call his son "Lisias" too about 30 years ago, and this kid happened to be the leader of a music band leader here in Brazil nowadays, and he ended up grabbing the name "Lisias" on some social networks in the last few years. "LisiasT" was the logical workaround.

Frankly, I don't know (yet) how to solve this problem. I'm "Lisias" about 20 years earlier :) but still…

The "replaced-by" sounded logical after I had read the documentation looking for what to do - but, frankly, I'm fine with any other solution.

About the KSPe stunt, I was planning to properly release it on SpaceDock & CKAN last year, but RealLife™ Striked Again and it ended up being delayed. KSPe is the future, the KSPe.Light had run its course and will be phased out. Currently, we are in the phasing out. I plan to start pushing KSPe first using Impossible Innovations, and then going up one add'on by add'on in crescent order of popularity. Right now, KSPe is not a dependency yet.

The tags sound perfect, thank you.

About the relationships, not at this time. I will climb my way from Impossible Innovations first.

I prefer the current status quo about the download options. I use github for earlier (manual) adopters, then climb to CurseForge and finally to SpaceDock (and CKAN) by last. Historically, this M.O. prevented a lot of headaches caused by some stupid misthaps I'm prone to do now and then. By the time the thing reaches the masses on CKAN, any obvious mistakes would had been detected most of the time.

Thanks.

@JonnyOThan
Copy link
Contributor Author

JonnyOThan commented Feb 7, 2024

If you don't have a preference on Lisias vs LisiasT, then I'd suggest just sticking with Lisias since all the automated PRs from Spacedock will be using that.

Since that’s the username on Spacedock, automated systems will work better this way.  Can always be changed later anyway
@JonnyOThan JonnyOThan merged commit 2992710 into master Feb 7, 2024
1 check passed
@JonnyOThan JonnyOThan deleted the transfer/KourageousTourists branch February 7, 2024 01:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants