Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add maintainers field #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add maintainers field #19

wants to merge 2 commits into from

Conversation

janbrohl
Copy link
Collaborator

While this field is only in the spec as an example for extensions I personally think it should be included.

@janbrohl
Copy link
Collaborator Author

Waiting for echo...

@mheguy
Copy link
Contributor

mheguy commented May 31, 2016

Presently the tool doesn't create a PR and as such they can't name the maintainer of the metadata as it'll likely be a team member who creates a PR from the issue ticket.

Further, the maintainer is often confused for being the maintainer of the mod rather than the maintainer of the metadata. For clarity and simplicity it would be easier to ask for the submitter's name outright.

@janbrohl
Copy link
Collaborator Author

suggestion for name in json output? x_submitter?

@mheguy
Copy link
Contributor

mheguy commented May 31, 2016

My suggestion is to use their name as x_maintained_by once the tool submits PRs. For the time being I don't see a use for it.

@janbrohl janbrohl changed the title Add add maintainers field Add maintainers field Jun 2, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants