Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

JOSS Review - Blocking Issue - LICENSE File #11

Closed
rlizzo opened this issue Nov 5, 2018 · 2 comments
Closed

JOSS Review - Blocking Issue - LICENSE File #11

rlizzo opened this issue Nov 5, 2018 · 2 comments

Comments

@rlizzo
Copy link

rlizzo commented Nov 5, 2018

This is a Blocking issue for the project's JOSS Submission: openjournals/joss-reviews#1065

Two things:

  1. Remove the .md from the LICENSE.md file. It is important to have a pure plain text license file (which it not markdown formatted) for automated LICENSE finders to include appropriately.

  2. Please list the applicable licenses for VMTK / VTK / ITK (and other dependent projects), basically, copy paste (and modify where appropriate) the VMTK LICENSE file

hkjeldsberg added a commit that referenced this issue Nov 6, 2018
hkjeldsberg added a commit that referenced this issue Nov 6, 2018
@aslakbergersen
Copy link
Collaborator

@rlizzo Thank you for pointing this out. We were actually a bit unsure on how to properly use the LICENSE. If you are pleased with the corrections we can close this issue.

Just to check, are the smaller version of the LICENCE on top of each file sufficient?

aslakbergersen added a commit that referenced this issue Nov 7, 2018
@rlizzo
Copy link
Author

rlizzo commented Nov 27, 2018

Hi @aslakbergersen, sorry for the late reply, yes it is sufficient. Closing due to completion of task! Thank you!

@rlizzo rlizzo closed this as completed Nov 27, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants