This repository was archived by the owner on Mar 9, 2025. It is now read-only.
review fixes for #105 #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurzhan-saktaganov
force-pushed
the
nsaktaganov_review_fixes_for_105
branch
3 times, most recently
from
8783459 to
46ec8ea
Compare
* ClusterBootstrap: eliminate direct access to r.idToReplicaset * replace github links to master branch with permalinks * hide router's concurrent data under interface 'routerConcurrentData' to prevent misusage by developers
nurzhan-saktaganov
force-pushed
the
nsaktaganov_review_fixes_for_105
branch
from
46ec8ea to
6e34cfd
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 67.33% 67.31% -0.03%
==========================================
Files 13 14 +1
Lines 1344 1343 -1
==========================================
- Hits 905 904 -1
Misses 377 377
Partials 62 62 ☔ View full report in Codecov by Sentry. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):
Related issues: