Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Nette 3.0 #23

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Nette 3.0 #23

merged 2 commits into from
Aug 22, 2019

Conversation

haltuf
Copy link
Contributor

@haltuf haltuf commented Jul 18, 2019

Rewrite to ConfigSchema + fix incompatibilities with Kdyby\Doctrine.
A necessary prerequisite for updating Kdyby\Doctrine to support Nette v3.0

enumag
enumag requested changes Jul 21, 2019
View reviewed changes
src/DI/AnnotationsExtension.php Outdated Show resolved Hide resolved
@enumag
Copy link
Member

enumag commented Jul 23, 2019

ping @haltuf

Also check #11 if there is anything there we should use.

@enumag enumag mentioned this pull request Aug 12, 2019
Merged
@haltuf
Copy link
Contributor Author

haltuf commented Aug 22, 2019

Also check #11 if there is anything there we should use.

@enumag I don't think so, the PR is based on (IMO) wrong understanding of the changes in Nette/DI in 3.0 version. ::validateConfig is deprecated and renaming the method to the getModifiedConfig() is quite a non-standard approach.

@enumag enumag merged commit 105e30a into Kdyby:master Aug 22, 2019
@enumag
Copy link
Member

enumag commented Aug 22, 2019

Thank you!

@enumag enumag mentioned this pull request Aug 22, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@enumag enumag enumag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haltuf @enumag