Skip igbinary tests if extension not available (#192)

Kevinrob · Oct 7, 2024 · 7e4e9ee · 7e4e9ee
1 parent 7508088
commit 7e4e9ee
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/tests/CacheEntryTest.php b/tests/CacheEntryTest.php
@@ -83,6 +83,9 @@ public function testTtlUsesMaximumPossibleLifetime()
         $this->assertEquals(70, $cacheEntry->getTTL());
     }
 
+    /**
+     * @requires extension igbinary
+     */
     public function testCacheEntryShouldBeSerializableWithIgBinaryWithoutWarning()
     {
         $request = new Request(
@@ -99,16 +102,12 @@ public function testCacheEntryShouldBeSerializableWithIgBinaryWithoutWarning()
         );
         $cacheEntry = new CacheEntry($request, $response, $this->makeDateTimeOffset(10));
 
-        if(extension_loaded('igbinary')) {
-            /**
-             * @var CacheEntry $cacheEntryPostDeserialization
-             */
-            $cacheEntryPostDeserialization = igbinary_unserialize(igbinary_serialize($cacheEntry));
-            $this->assertEquals((string)$cacheEntry->getOriginalRequest()->getBody(), (string)$cacheEntryPostDeserialization->getOriginalRequest()->getBody());
-            $this->assertEquals((string)$cacheEntry->getOriginalResponse()->getBody(), (string)$cacheEntryPostDeserialization->getOriginalResponse()->getBody());
-        } else {
-            $this->addWarning('Extension igbinary not loaded, not asserting serialization.');
-        }
+        /**
+         * @var CacheEntry $cacheEntryPostDeserialization
+         */
+        $cacheEntryPostDeserialization = igbinary_unserialize(igbinary_serialize($cacheEntry));
+        $this->assertEquals((string)$cacheEntry->getOriginalRequest()->getBody(), (string)$cacheEntryPostDeserialization->getOriginalRequest()->getBody());
+        $this->assertEquals((string)$cacheEntry->getOriginalResponse()->getBody(), (string)$cacheEntryPostDeserialization->getOriginalResponse()->getBody());
     }
 
     public function testSerializationShouldNotMutateCacheEntry()