Added header to allow dynamic ttl per request when using greedy cache #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevinrob
reviewed
Nov 21, 2017
src/Strategy/GreedyCacheStrategy.php
Outdated
| if ($request->hasHeader(self::HEADER_TTL)) { | ||
| $ttlHeaderValues = $request->getHeader(self::HEADER_TTL); | ||
| $ttl = (int)reset($ttlHeaderValues); | ||
| unset($ttlHeaderValues); |
There was a problem hiding this comment.
it was just to not keep a variable that has no purposes. I would prefer to not create it but reset takes only variables. Do you prefer I remove this line @Kevinrob ?
|
Thanks for the PR! |
|
@Kevinrob : I'll try to add some tests. I'll let you know ;) |
|
@Kevinrob : In fact I don't see how to write this tests as no other tests are ttl oriented. |
|
Okay, I will check for adding tests! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #98