Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add PSR-16 support #97

Merged
merged 3 commits into from
Nov 13, 2017
Merged

add PSR-16 support #97

merged 3 commits into from
Nov 13, 2017

Conversation

renanbr
Copy link
Contributor

@renanbr renanbr commented Nov 10, 2017

No description provided.

@renanbr
Copy link
Contributor Author

renanbr commented Nov 10, 2017

Tests are green in PHP 5.6 and 7, but failing in those version:

  • 5.5, because cache/simple-cache-bridge requires 5.6;
  • HHVM, I have no idea what happens

I can go further if you consider this patch pertinent

@Kevinrob
Copy link
Owner

Nice! Thank you for the PR @renanbr !

HHVM isn't supported anymore by Doctrine\Cache... I think that I will remove it (see doctrine/cache#219)
For PHP 5.5... Is it still used? 🤔

@Kevinrob
Copy link
Owner

@renanbr When you write I can go further if you consider this patch pertinent. What did you mean? Is there anything that you want to add before I merge the PR?

@renanbr
Copy link
Contributor Author

renanbr commented Nov 12, 2017

I was talking about PHP 5.5 test failure, but I think I solved it changing cache/simple-cache-bridge constraint requirement from ^1.0 to ^0.1 || ^1.0, because 0.1.0 works on PHP 5.5.

From my side it's ready to merge :-)

@Kevinrob Kevinrob merged commit de3d632 into Kevinrob:master Nov 13, 2017
@renanbr renanbr deleted the psr-16 branch November 13, 2017 11:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants