Darkmode #1322
Merged
Darkmode #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed for wxStaticBoxSizer because it contained a parent window. However, all the other sizers need to ensure they didn't hide the children if the user has the Show Hidden toggle button on.
This also displays the dark mode settings in the Preferences dialog when run under Windows.
This includes the information about Dark Mode now being available.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a delay flag when dark mode is changed, and the actual value is not changed until the app is closed and
Prefs::WriteConfig()is called. This avoids the crash called by turning off dark mode while dark colors are still in use.The second part of this PR enables the Dark Mode setting on Windows in the Preferences dialog.
Closes #1273