Change when to generate wxue function declaration/definition #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is an Image List file, then all wxue functions are in that file, and declared in the header file that is #included in the source file. If there is no Image List file, then either a declaration or definition must be generated.
Because of this issue, any time this file is generated, it has to be manually reformatted with clang-format.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an Image List file, then all wxue functions are in that file, and declared in the header file that is #included in the source file.
If there is no Image List file, then either a declaration or definition must be generated.
This PR fixes a regression caused by #1323. While that PR improved code generation if there is an Image List file, it broke code generation if there is no Image List file. This PR fixes that regression.
Create a copy of sdi called sdi_31 which does not have an Image List file and is set to generate 3.1 compatible code. This would provide testing for the more common scenario of no Image List file, while at the same time verifying that code generation for wxWidgets 3.1 is working correctly.
KeyWorksRW/wxUiTesting#19 was created in part to track any potential problems between projects with and without Image List files.