Move props/events from AddPropsAndEvents() back into XML files #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easier to update the XML file rather than the generator, and contents get compressed if in the XML file for an added bonus. This is mostly a proof of concept to see how hard it is to move the AddPropsAndEvents() back into the XML files.
Required if this is in an XML file
I move all the properties and events set by the generators back into the XML files now that they no longer have size limits, or restrictions on comments, spacing, etc.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the AddPropsAndEvents() that generators could use to add props and events. Instead, I moved all the properties and events back into the XML files.
The reason for this is that now that we no longer have size limits for the XML files, and we can add comments and whatever spacing adds to readability, the XML files become more useful for setting generator properties and events, while adding compression and faster parsing using the Data List functionality.