Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix crash in Book Pages that specify an unrecognized ART id #1362

Merged
merged 2 commits into from
Jan 1, 2024

Conversation

Randalphwa
Copy link
Collaborator

This PR creates a new unknown.svg file in Images List, and uses that when a Book page tries to load a bundle that has artwork that wxUiEditor doesn't know about. This can occur with custom ART providers. Without the replacement bundle, wxWidgets will crash.

This fixes the wxUiEditor side of the crash referred to in #1359 but leaves the issue open because the wxWidgets code needs to be fixed as well.

Using an SVG means it can be sized to whatever would be closest to the size
of the missing artwork.
If a node's bundle is not valid (see #1359) then add bundle_unknown_svg()
as a placeholder.
@Randalphwa Randalphwa merged commit 9af3a36 into main Jan 1, 2024
@Randalphwa Randalphwa deleted the art_provider branch January 1, 2024 16:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant