Switch compiler standard to std:c++latest #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These versions take two parameters with the second parameter having a default. The advantage of these versions is you can search case-insensitively.
Since CMake will no longer require this directly (it uses std::c++latest instead) there has to be a check in the precompiled header that will fail with a compiler that is too old.
std::unique_ptr<WakaTime> fails under C++23.
The precompiled header prevents compiling the project with an older version. This verifies that versions beyond the required version will still work.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the C++20 requirement from CMakeLists.txt and places the check in the precompiled header instead. That made it possible to use -std::c++latest as the compiler. With MSVC, that's going to be C++23 which resulted in some errors that needed fixing. By always using the latest standard, we can avoid having compiler problems due to changing standards in the future.
Note that c++latest can not be used currently for compiling the wxWidgets library -- that will require fixes to wxWidgets itself.