Replace some calls to wxMessageBox with wxMessageDialog #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for those times when returning std::string is needed instead of returning tt_string.
These get used in multiple places, so easiest to have a common module for them.
Filenames can be truncated in wxMessageBox, so this switches some of the importer and code generation messages to use wxMessageDialog instead.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new dlg_msgs src/hdr module which supplies functions for calling wxMessageDialog. These are used to replace some of the calls to wxMessageBox when a full file path needs to be displayed. This can be truncated in wxMessageBox, hence the switch to wxMessageDialog.
The rest of the changes are straightforward replacements of wxMessageBox with wxMessageDialog.