Improve node selection handling in language panels #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For C++ panels, this will find the function used to load the image. For Python and Ruby panels, this will find the variable of the selected image.
For Ribbon tools, this avoids selecting a wxToolBar tool by mistake if there is one in the same form with the same artwork.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates special functions for handling a selected node when one of the Language panels is displayed. Using functions means there can be a lot more logic for specific nodes such as Image List images and Ribbon tools and buttons. Otherwise, the main search functions would become increasingly long and complex, making it harder to find the code for handling a specific node type.
Closes #1377