Update Navigation panel Popup menu #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will *only* add a separator if the previous menu item is not already a separator or there are no menu items. This prevents duplicate separators, or complex logic to determine if we need one or not.
Returning false means you don't want to be followed with sizer menus
Refactor to avoid issues of duplicate separators, and missing or non-valid menu items depending on what is selected.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problems with the context menu invoked from the Navigation panel. It prevents duplicate separators, fixes some missing menu items on some controls, as well as removing some that were invalid.