Extend Data List functionality #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous commit verified that it *could* work at least in terms of getting the correct filename. However, actually supporting writing additional files that aren't actually a form would be somewhat involved. I've commented it out, so it could be added back at some point if it's deemed worthwhile to implement generating different files.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the support for Data Lists. It now supports folders (for organization only) as well as non-compressed files. Compressed files are assumed to be strings, so the function calls return
std::string. Non-compressed files are assumed to be binary, so the function calls return astd::pair<const unsigned char*, size_t>giving you a pointer to the data and the size of the data.