Update Preferences Dialog #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears to be 8 in the current scintilla in wxWidgets 3.3, so this forces it to 4 to improve readability.
Coupled with the new getLangPanel methods in mainframe, this enables changing the color of a panel from anywhere.
This is now used in the PreferencesDlg
If FAIL_MSG() is called during event processing, it could result in being called multiple times until it finally crashes.
Add more colors, version string, font.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the Preferences Dialog. It adds the ability to set the font to use in the various code display panels. It also expands the colors that can be set, while removing the need to restart wxUiEditor after the user changes one or more colors. It also adds versions to wxPython and wxRuby (currently only one version available for each, but could be expanded in the future). It adds 3.3 to the C++ wxWidgets versions.
Note that the Ruby lexer doesn't support a second set of keywords, and doesn't correctly set the color for quoted strings (any of the 6 variants of string types).