Change how unsupported XRC widget can have a comment to that effect #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the generator returns xrc_not_supported and also returns a GetWarning message for GEN_LANG_XRC, then create an empty wxBoxSizer and add the warning message. This makes it possible for the generator to add a comment about the widget not being supported in XRC, but without affecting the UI.
Currently, XRC doesn't support this, so this uses the new mechanism for generating a warning.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for generators that XRC doesn't support, to add a comment to the XRC file that will not change the visible UI.
Closes #1552