Improve chance that XRC preview will find the artwork. #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since XRC art files don't have full paths. setting the current directory to any directory specified for Art may result in the files being loaded correctly.
In most cases the user will want to preview a specific dialog, so this displays the possible dialogs first, letting the user then choose which one to view.
This shouldn't matter for C++ which will be using embedded art, but for XRC it increases the chance that it will load the requested art (which doesn't have a path specifier).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the current working directory to the Art Directory (or Project file directory if Art Directory hasn't been specified) before previewing XRC files. The generated XML file has no way of knowing where the art files will be relative to the current directory of the app loading the XRC file. By setting the current working directory to the likely location of the art files, this should result in most art work being displayed when previewing XRC content.