Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build x86 + arm builder images #254

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Conversation

ivanychev
Copy link
Contributor

@ivanychev ivanychev commented Jul 19, 2022

  • Build keyvidev/manylinux-builder-x86_64 and keyvidev/manylinux-builder-aarch64. The keyvidev/manylinux-builder tag remains alias to keyvidev/manylinux-builder-x86_64
  • Update zlib used in the build since the older URL returns 404

Copy link
Member

@narekgharibyan narekgharibyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivanychev for your contribution.

Before we merge this, I have added a few suggestions.

@ivanychev ivanychev requested a review from narekgharibyan July 19, 2022 07:14
Copy link
Member

@narekgharibyan narekgharibyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ivanychev I have pushed both images:

keyvidev/manylinux-builder-x86_64
keyvidev/manylinux-builder-aarch64

Will merge this along with other PR, that makes use of images.

Copy link
Contributor

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivanychev! LGTM

@narekgharibyan narekgharibyan merged commit e141991 into KeyviDev:master Jul 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants