Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable buffer methods before needing to call StyleSheetServer.renderStatic #342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DaBs
Copy link

@DaBs DaBs commented Aug 31, 2018

Currently, Aphrodite assumes that it is the first server-side module to render the tree, but
since StyleSheetServer.renderStatic expects a string as return value, it eliminates any possibility of walking the reference with another module.

This PR borrows some of the TestUtils functions to allow a, albeit a bit clunky, method of avoiding having to append classes to the DOM while walking an existing reference to a tree.

@khanbot
Copy link

khanbot commented Aug 31, 2018

Hey @DaBs,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@DaBs
Copy link
Author

DaBs commented Aug 31, 2018

[clabot:check]

@khanbot
Copy link

khanbot commented Aug 31, 2018

CLA signature looks good 👍

@DaBs
Copy link
Author

DaBs commented Sep 1, 2018

@lencioni I believe you guys have been in need of a fix to this as per #326. Is this something you would consider reviewing?

@DaBs
Copy link
Author

DaBs commented Sep 19, 2018

@jlfwong Is this something you know if people within the project has time to look at? I believe it's quite a nice way of giving some manual tools for people to be able to temporarily suspend aphrodite style rendering when it comes to SSR.

@monokrome
Copy link

I'm running into this issue as well! Any chance this will be merged & released any time soon? :)

@mishkinf
Copy link

mishkinf commented Feb 5, 2019

@jlfwong and @lencioni is there any way somebody can look into merging this fix?

moaazsidat added a commit to moaazsidat/aphrodite that referenced this pull request Apr 19, 2020
@monokrome
Copy link

Y'all, this has been an issue for quite a long time now...

@drianoaz
Copy link

drianoaz commented Feb 11, 2021

Man, I has a problems that this PR will resolve. Has plans to merge it? The problem is the below:

Error: Cannot automatically buffer without a document

@jlfwong can you help us?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants