Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

replaces calls to LoadLibrary with explicit calls to LoadLibraryA #216

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

bashbaug
Copy link
Contributor

fixes #208

Since we're unconditionally passing an ascii string, unconditionally call LoadLibraryA instead of LoadLibrary. This ensures that the correct function is called even if somebody compiles the OpenCL ICD loader with UNICODE support.

@bashbaug
Copy link
Contributor Author

Merging as discussed in the April 11th teleconference.

@bashbaug bashbaug merged commit b1bce7c into KhronosGroup:main Apr 11, 2023
@bashbaug bashbaug deleted the fix-unicode-errors branch April 11, 2023 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect usage of LoadLibrary and string literal
2 participants