-
-
Notifications
You must be signed in to change notification settings - Fork 382
XR Volume Rendering #2322
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Investigation results:
|
@floryst Reminder that this exists, no particular rush though. Would be helpful to have 1) any console printouts from volume rendering on Android and 2) your thoughts on parameters that might affect the clipping plane, which seems to be set to the default (far plane 1000.0) |
I got the "Start AR" button to work with some CSS modification, and got a volume to show up in AR on the Touching the screen did throw the following error (
I'm also experiencing the clipping plane issue. The range should be much wider in order, otherwise it's difficult to use. |
If I invoke |
FYI @tbirdso to fix the clipping issue, we can add conditionals for the VR version of resetCamera and resetCameraClippingRange, as seen here: https://github.com/Kitware/VTK/blob/master/Rendering/VR/vtkVRRenderer.cxx |
I experimented a bit with resetting clipping planes for AR last Friday. Increasing the far clip plane helped significantly and seemed to correspond neatly to real-world distances. However, the near clipping plane to anything farther than 0.1 or so seemed to reduce the far clip distance rather than moving the near clip plane outward, which was unexpected. Unclear if this is an issue specific to WebXR, need to experiment further. Do we have an example for adjusting a camera's clipping planes without XR that I could use as a baseline? |
There isn't any example that adjusts the clipping range IIRC. You can take the volume rendering example and adjust the camera clipping range manually via devtools, or add a small slider UI for near/far. |
I'm not familiar with any behavior that would force the far clipping range to move closer if you reduce the near clipping plane to below 0.1. I would be interested to know if that occurs with the regular renderer. |
I was not able to reproduce the clipping issue by playing around with the Cone example, the near and far clip planes were adjustable with I will investigate whether something strange might be happening with our physical-to-view transformation in XR rendering. EDIT: I also get expected near clipping behavior when experimenting with data in |
@floryst I am getting a bit confused on this one. From what I can tell Could you please comment on how |
|
Thanks, I think that makes sense. Maybe the problem does not lie there then. Will keep digging. |
Collecting thoughts so far:
|
@floryst I am switching gears to focus on #2442. If you have the time I think I need more help to make progress on this issue, my knowledge of VTK's volume clipping procedures is limited and I'm hitting a wall on what I know to investigate. Would appreciate input from someone else who is more familiar with what could be causing the behavior I've described above. |
🎉 This issue has been resolved in version 24.16.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Need
WebXR examples currently only encompass surface rendering. It would be useful to add an example demonstrating volume rendering as well.
Feature
Two changes are needed:
AR volume rendering was previously observed to work in the WebXR Emulator but the vtk.js scene did not appear when viewing on mobile.
The text was updated successfully, but these errors were encountered: