Skip to content

docs(XR): add WebXR volume rendering example #2449

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2022
Merged

docs(XR): add WebXR volume rendering example #2449

merged 1 commit into from
Jun 6, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Jun 2, 2022 •
edited
Loading

Context

Adds a basic example to demo volume rendering in VR/AR with WebXR.

Similar to "VolumeViewer" example but with reduced UI components for simplicity. ".vti" files can be provided with "fileURL" parameter.

The clipping range is set to a very large span by default so that the initial volume is always visible in AR. There are lingering issues with the camera clipping range when using WebXR that are not addressed in this PR.

Results

Inline

WebXRVolume

AR

ar-volume

VR

vr-volume

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • Tested environment:
    • vtk.js: master
    • OS: Windows 10
    • Browser: Chrome 102.0.5005.63

Closes #2322 .

@tbirdso tbirdso requested review from floryst, martinken and JiayiXuu June 2, 2022 20:30
@tbirdso
Copy link
Contributor Author

tbirdso commented Jun 3, 2022

cc @PaulHax

martinken
martinken approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@martinken martinken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Very nice! +1

PaulHax
PaulHax approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nifty!

@tbirdso tbirdso force-pushed the webxr-volume-example branch from 14f9668 to 87bcb85 Compare June 3, 2022 15:57
JiayiXuu
JiayiXuu approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@JiayiXuu JiayiXuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

@floryst floryst merged commit 3273e25 into Kitware:master Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

🎉 This PR is included in version 24.16.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jun 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@PaulHax PaulHax PaulHax approved these changes

@floryst floryst floryst approved these changes

@martinken martinken martinken approved these changes

@JiayiXuu JiayiXuu JiayiXuu approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XR Volume Rendering
5 participants
@tbirdso @floryst @martinken @PaulHax @JiayiXuu