feat(WebGPU): support more data types for volume rendering #2069
Conversation
martinken
force-pushed
the
webgpu_half_float_support
branch
from
f6f6945 to
39fcfb3
Compare
|
@jourdain PTAL mainly at the typescript stuff |
| */ | ||
|
|
||
| /** | ||
| * Convert a Base64 string to an ArrayBuffer. |
There was a problem hiding this comment.
Is that the real description?
There was a problem hiding this comment.
See that is why I have you review it :-) But really I was worried about the types I chose to use.
There was a problem hiding this comment.
number is fine, but now, I just noticed that you export both function as default.
That is wrong. You should export your function as-is (no default keyword).
Then add at the bottom
export default {
toHalf,
fromHalf,
};
There was a problem hiding this comment.
By doing that also in your JS you should export your function as well. That would allow someone to import them individually to match the TS description.
There was a problem hiding this comment.
or maybe
export declare const HalfFloat: {
toHalf: typeof toHalf;
fromHalf: typeof fromHalf;
}
export default HalfFloat;
39fcfb3 to
d6c9772
Compare
Use half float to support types other than uint8 Fix a matrix computation that impacts imageData that has a direction in its transformations.
martinken
force-pushed
the
webgpu_half_float_support
branch
from
d6c9772 to
f7c05b3
Compare
|
🎉 This PR is included in version 19.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Use half float to support types other than uint8
Fix a matrix computation that impacts imageData that
has a direction in its transformations.