Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(rollup): force .js extension for all files #2074

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Sep 24, 2021

All assets are considered js files. This ensures that bundlers treat
imports correctly, as some of the generated imports do not suffix with a
proper extension.

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Context

Fixes #2072

Changes & Results

  • [ESM] Forces all output chunks to end with .js

Testing

  • This change adds or fixes unit tests
  • All tests complete

All assets are considered js files. This ensures that bundlers treat
imports correctly, as some of the generated imports do not suffix with a
proper extension.
@floryst floryst merged commit 4e9d47f into Kitware:master Sep 24, 2021
@floryst floryst deleted the rollup-force-js-ext branch September 24, 2021 21:01
@github-actions
Copy link

🎉 This PR is included in version 19.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Sep 24, 2021
@weeeina
Copy link

weeeina commented Sep 24, 2021

Hi @floryst, I really appreciate your prompt response to my bug #2072

Now, I get a brand new (and possibly related) import error:
image

Let me know if I should file another bug ticket for this. Again, thanks for responding so quickly!

Update: this seems to have resolved with a fresh local deployment. I'll follow up if I see it again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error importing randomseed alea
2 participants