2434 vtk poly data normals add compute cell normals #2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floryst
reviewed
Sep 11, 2023
Sources/Filters/Core/PolyDataNormals/test/testPolyDataNormals.js
Outdated
Show resolved
Hide resolved
finetjul
force-pushed
the
2434-vtkPolyDataNormals-add-computeCellNormals
branch
from
4708064 to
2a01f83
Compare
floryst
reviewed
Sep 13, 2023
finetjul
force-pushed
the
2434-vtkPolyDataNormals-add-computeCellNormals
branch
from
2a01f83 to
83a2f8b
Compare
|
I'll check the failing tests... |
There is a rendering crash when no point nor cell normals are available
finetjul
force-pushed
the
2434-vtkPolyDataNormals-add-computeCellNormals
branch
from
c0ee3f1 to
f017f65
Compare
|
LGTM |
|
🎉 This PR is included in version 28.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
fix #2434
Results
Add
setComputePointNormalsandsetComputeCellNormalsChanges
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting