Skip to content

fix(RWInteractor): async requestPointerLock #3205

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(RWInteractor): async requestPointerLock #3205

wants to merge 1 commit into from

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Jan 16, 2025 •
edited
Loading

Context

Chrome 131+ now requests permissions for pointer lock. We need to ensure that pointer lock is achieved before continuing with interactions.

Results

  • support async requestPointerLock

Changes

  • all calls to requestPointerLock have been updated
  • examine whether methods calling requestPointerLock should be made async

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@danyim
Copy link

danyim commented Mar 13, 2025

I just verified this change in https://github.com/SironaMedical/services-frontend/pull/6140 - looks good to me! Could we get this merged?

@floryst floryst marked this pull request as ready for review March 14, 2025 17:33
@floryst floryst force-pushed the requestpointerlock-async branch from 7240b49 to 73ab82f Compare March 14, 2025 17:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floryst @danyim